yanghua commented on a change in pull request #2122:
URL: https://github.com/apache/hudi/pull/2122#discussion_r496439235
##########
File path:
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/SlashEncodedDayPartitionValueExtractor.java
##########
@@ -36,30 +36,35 @@
private static final long serialVersionUID = 1L;
private transient DateTimeFormatter dtfOut;
- public SlashEncodedDayPartitionValueExtractor() {
Review comment:
If you try to support hourly partition, then this name is not suitable.
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
