voonhous commented on code in PR #12539: URL: https://github.com/apache/hudi/pull/12539#discussion_r1897414282
########## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/state/upgrade/source/StreamReadMonitoringStateUpgrader.java: ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.state.upgrade.source; + +import org.apache.hudi.common.table.HoodieTableMetaClient; +import org.apache.hudi.common.util.ValidationUtils; +import org.apache.hudi.state.upgrade.StateUpgrader; +import org.apache.hudi.state.upgrade.StateVersion; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.Arrays; +import java.util.List; + +public class StreamReadMonitoringStateUpgrader implements StateUpgrader<String> { + + private static final Logger LOG = LoggerFactory.getLogger(StreamReadMonitoringStateUpgrader.class); + + private final HoodieTableMetaClient metaClient; + private final String issuedInstant; + + public StreamReadMonitoringStateUpgrader(HoodieTableMetaClient metaClient, String issuedInstant) { + this.metaClient = metaClient; + this.issuedInstant = issuedInstant; + } + + @Override + public List<String> upgrade(List<String> oldState, StateVersion fromVersion, StateVersion toVersion) { + switch (fromVersion) { + case V1: + if (toVersion == StateVersion.V2) { + return upgradeV1ToV2(oldState); + } + case V2: + // Do nothing + return oldState; + default: + throw new IllegalStateException("Unsupported version upgrade path"); + } + } + + @Override + public boolean canUpgrade(StateVersion fromVersion, StateVersion toVersion) { + return fromVersion.getValue() < toVersion.getValue(); + } + + private List<String> upgradeV1ToV2(List<String> oldState) { + ValidationUtils.checkState(oldState.size() == 1, "Retrieved state must have a size of 1"); + + // this is the case where we have both legacy and new state. + // the two should be mutually exclusive for the operator, thus we throw the exception. + ValidationUtils.checkState(this.issuedInstant != null, + "The " + getClass().getSimpleName() + " has already restored from a previous Flink version."); + + String issuedInstant = oldState.get(0); + + // TODO 1: Find issuedOffset by querying for completion time using metaClient's active offset + // TODO 2: If issuedInstant (requestInstant) is in archive timeline, how do we handle that, should we throw an error? Review Comment: @danny0405 Not sure on how to handle this, but should we be querying the archived timeline for the completion time if the `issuedInstant` is not in the active timeline. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
