TheR1sing3un opened a new pull request, #12559: URL: https://github.com/apache/hudi/pull/12559
When `HoodieFileSliceReader` performs reading: For base records that have a corresponding update record in the log file, it first converts the HoodieAvroIndexRecord format that it reads from the Base Reader to the HoodieAvroRecord format. Then when it performs the merge, it convert itself to the HoodieAvroIndexRecord, and since it was the HoodieAvroIndexRecord in the first place, this extra conversion is not necessary. `HoodieFileSlice` <img width="1157" alt="image" src="https://github.com/user-attachments/assets/fbfccea6-5307-48b3-9bfc-555f4db2edd3"; /> `HoodieAvroRecordMerger` <img width="1413" alt="image" src="https://github.com/user-attachments/assets/03754ded-23fb-4e01-ba02-93098205bd7b"; /> ### Change Logs 1. avoid unnecessary conversion between HoodieIndexAvroRecord and HoodieAvroRecord in HoodieFileSliceReader _Describe context and summary for this change. Highlight if any code was copied._ ### Impact low _Describe any public API or user-facing feature change or any performance impact._ ### Risk level (write none, low medium or high below) low _If medium or high, explain what verification was done to mitigate the risks._ ### Documentation Update none _Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none"._ - _The config description must be updated if new configs are added or the default value of the configs are changed_ - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make changes to the website._ ### Contributor's checklist - [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute) - [x] Change Logs and Impact were stated clearly - [x] Adequate tests were added if applicable - [x] CI passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
