TheR1sing3un commented on code in PR #12537:
URL: https://github.com/apache/hudi/pull/12537#discussion_r1900523390
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/clustering/run/strategy/SingleSparkJobExecutionStrategy.java:
##########
@@ -79,94 +54,25 @@ public SingleSparkJobExecutionStrategy(HoodieTable table,
HoodieEngineContext en
@Override
public HoodieWriteMetadata<HoodieData<WriteStatus>> performClustering(final
HoodieClusteringPlan clusteringPlan, final Schema schema, final String
instantTime) {
- JavaSparkContext engineContext =
HoodieSparkEngineContext.getSparkContext(getEngineContext());
final TaskContextSupplier taskContextSupplier =
getEngineContext().getTaskContextSupplier();
final SerializableSchema serializableSchema = new
SerializableSchema(schema);
final List<ClusteringGroupInfo> clusteringGroupInfos =
clusteringPlan.getInputGroups().stream().map(ClusteringGroupInfo::create).collect(Collectors.toList());
- String umask =
engineContext.hadoopConfiguration().get("fs.permissions.umask-mode");
Review Comment:
None of this logic is valid, and the class hasn't been used anywhere before,
so I refactor this part of the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
