nsivabalan commented on code in PR #12490:
URL: https://github.com/apache/hudi/pull/12490#discussion_r1906162841
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/clustering/run/strategy/MultipleSparkJobExecutionStrategy.java:
##########
@@ -575,7 +575,7 @@ public Iterator<InternalRow> call(ClusteringOperation
clusteringOperation) throw
getHoodieTable().getMetaClient(),
getHoodieTable().getMetaClient().getTableConfig().getProps(),
0,
- Long.MAX_VALUE,
+ -1,
Review Comment:
can we add java doc here as to why we are setting it to -1 ?
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/clustering/run/strategy/MultipleSparkJobExecutionStrategy.java:
##########
@@ -575,7 +575,7 @@ public Iterator<InternalRow> call(ClusteringOperation
clusteringOperation) throw
getHoodieTable().getMetaClient(),
getHoodieTable().getMetaClient().getTableConfig().getProps(),
0,
- Long.MAX_VALUE,
+ -1,
Review Comment:
on second thought, why can't we deduce base file or bootstrap file and
deduce file lenght here only and keep the file group reader simple ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
