TheR1sing3un commented on code in PR #12537:
URL: https://github.com/apache/hudi/pull/12537#discussion_r1908131969
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/functional/TestSparkConsistentBucketClustering.java:
##########
@@ -110,7 +115,7 @@ public void setup(int maxFileSize, Map<String, String>
options) throws IOExcepti
.withStorageConfig(HoodieStorageConfig.newBuilder().parquetMaxFileSize(maxFileSize).build())
.withClusteringConfig(HoodieClusteringConfig.newBuilder()
.withClusteringPlanStrategyClass(SparkConsistentBucketClusteringPlanStrategy.class.getName())
-
.withClusteringExecutionStrategyClass(SparkConsistentBucketClusteringExecutionStrategy.class.getName())
+ .withClusteringExecutionStrategyClass(single ?
SINGLE_SPARK_CONSISTENT_BUCKET_EXECUTION_STRATEGY :
SPARK_CONSISTENT_BUCKET_EXECUTION_STRATEGY)
Review Comment:
> We should just keep one strategy if
`SINGLE_SPARK_CONSISTENT_BUCKET_EXECUTION_STRATEGY` is always better.
Yes, I will deprecated previous hash resizing execution in next pr.
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/functional/TestSparkConsistentBucketClustering.java:
##########
@@ -94,6 +95,10 @@ public void setup(int maxFileSize) throws IOException {
}
public void setup(int maxFileSize, Map<String, String> options) throws
IOException {
+ setup(maxFileSize, options, false);
+ }
+
+ public void setup(int maxFileSize, Map<String, String> options, boolean
single) throws IOException {
Review Comment:
> single -> singleJob
done~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
