yihua commented on code in PR #12615:
URL: https://github.com/apache/hudi/pull/12615#discussion_r1911778236
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -1271,10 +1272,24 @@ public TableBuilder fromProperties(Properties
properties) {
setTableName(hoodieConfig.getString(HoodieTableConfig.NAME));
}
- if (hoodieConfig.contains(VERSION)) {
+ if (hoodieConfig.contains(VERSION) &&
hoodieConfig.contains(WRITE_TABLE_VERSION)) {
Review Comment:
The logic in meta client should not consider write table version.
Otherwise, there is no point checking whether `hoodie.write.table.version` and
`hoodie.table.version` match.
`CommonClientUtils#validateTableVersion` has the validation. Does Spark SQL
writer escape that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
