danny0405 commented on code in PR #12601:
URL: https://github.com/apache/hudi/pull/12601#discussion_r1912740846
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/strategy/CompactionStrategy.java:
##########
@@ -71,10 +76,14 @@ public Map<String, Double> captureMetrics(HoodieWriteConfig
writeConfig, FileSli
* @return Compaction plan to be scheduled.
*/
public HoodieCompactionPlan generateCompactionPlan(HoodieWriteConfig
writeConfig,
- List<HoodieCompactionOperation> operations, List<HoodieCompactionPlan>
pendingCompactionPlans) {
+ List<HoodieCompactionOperation> operations, List<HoodieCompactionPlan>
pendingCompactionPlans, Map<String, String> params, Pair<List<String>,
List<String>> partitionPair) {
// Strategy implementation can overload this method to set specific
compactor-id
+ Set<String> missingPartitions = new HashSet<>(partitionPair.getRight());
+ List<HoodieCompactionOperation> operationsToProcess =
orderAndFilter(writeConfig, operations, pendingCompactionPlans,
missingPartitions);
+ List<String> res = writeConfig.isIncrementalTableServiceEnable() ? new
ArrayList<>(missingPartitions) : new ArrayList<>();
Review Comment:
Maybe null as the default value to avoid deserialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
