Karl-WangSK commented on pull request #2106:
URL: https://github.com/apache/hudi/pull/2106#issuecomment-703564330
> @Karl-WangSK Can this kind of merging should belong in a separate payload
class. I am not sure overloading the existing payload is the right way to go.
It has a specific purpose of ingesting full change log records, and pick the
latest record based on `orderingVal`. What I am trying to say : there may be
users who just want `null, 18` i.e latest values for name,age instead of merged.
>
> Happy to take this contribution as a separate payload class .
In `HoodieWriteConfig`. I added `COMBINE_ALL_FIELDS_BEFORE_UPSERT_PROP`,
and `DEFAULT_COMBINE_ALL_FIELDS_BEFORE_UPSERT` = "false". So it won't
merge(which means will choose latest values for name,age). If I want to enable
this function described in this PR, just set
`DEFAULT_COMBINE_ALL_FIELDS_BEFORE_UPSERT` as "true". I think it doesn't need
to add a new payload. wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
