[GitHub] [hudi] lw309637554 commented on a change in pull request #2142: [HUDI-1203] add port configuration for EmbeddedTimelineService

[GitBox]

lw309637554 commented on a change in pull request #2142:
URL: https://github.com/apache/hudi/pull/2142#discussion_r499544639



##########
File path: 
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieClient.java
##########
@@ -102,7 +102,8 @@ private synchronized void startEmbeddedServerView() {
         // Run Embedded Timeline Server
         LOG.info("Starting Timeline service !!");
         Option<String> hostAddr = 
context.getProperty(EngineProperty.EMBEDDED_SERVER_HOST);
-        timelineServer = Option.of(new EmbeddedTimelineService(context, 
hostAddr.orElse(null),
+        int embeddedTimelineServerPort = 
config.getEmbeddedTimelineServerPort();

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org