sharath1709 commented on code in PR #12666:
URL: https://github.com/apache/hudi/pull/12666#discussion_r1925862670
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java:
##########
@@ -473,6 +475,19 @@ private void handleEndInputEvent(WriteMetadataEvent event)
{
}
}
+ private void filterWriteFailure(WriteMetadataEvent event) throws
HoodieException {
Review Comment:
Can we reuse the same logic in doCommit as well to prevent any future
logical divergence in detecting write failures?
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java:
##########
@@ -473,6 +475,19 @@ private void handleEndInputEvent(WriteMetadataEvent event)
{
}
}
+ private void filterWriteFailure(WriteMetadataEvent event) throws
HoodieException {
Review Comment:
Can we reuse the same logic in doCommit method as well to prevent any future
logical divergence in detecting write failures?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
