prashantwason commented on a change in pull request #2064:
URL: https://github.com/apache/hudi/pull/2064#discussion_r501375567



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java
##########
@@ -174,8 +174,17 @@ public static String getRelativePartitionPath(Path 
basePath, Path fullPartitionP
   /**
    * Obtain all the partition paths, that are present in this table, denoted 
by presence of
    * {@link HoodiePartitionMetadata#HOODIE_PARTITION_METAFILE}.
+   *
+   * If thee basePathStr is a subdirectory of .hoodie folder then we assume 
that the partitions of an internal
+   * table (a hoodie table within the .hoodie directory) are to be obtained.
+   *
+   * @param fs FileSystem instance
+   * @param basePathStr base directory
    */
   public static List<String> getAllFoldersWithPartitionMetaFile(FileSystem fs, 
String basePathStr) throws IOException {
+    // If the basePathStr is a folder within the .hoodie directory then we are 
listing partitions within an
+    // internal table.
+    final boolean isInternalTable = 
basePathStr.contains(HoodieTableMetaClient.METAFOLDER_NAME);

Review comment:
       Done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to