Davis-Zhang-Onehouse commented on PR #12615: URL: https://github.com/apache/hudi/pull/12615#issuecomment-2616331416
@danny0405 > For creating new tables using 1.0, if there is a need to create one with older format, then writers should be configured with hoodie.write.auto.upgrade=false and hoodie.write.table.version=6. In this case, hoodie.table.version should also be 6. It means in hudi 1.0, if a user wants to create version 6 table, they would set the config above and the system should honor that configuration in metaClient.initTable. This is why this change enforces when metaClient is created, we set the table version to write version. This is what is missing without the change > For creating new tables using 1.0, by default i.e. when none of the writer configs are set, hoodie.table.version should be 8. hoodie.write.table.version is automatically inferred to be 8. With my change that explicitly set the write version, when user does not override the config, the version would be 8 automatically. For sake of unblocking the change soon by 101 cut off which is today @nsivabalan / @codope / @yihua does it make sense that we merge the PR first. If later Danny has any follow ups we can discuss tonight. Based on all the discussion so far I only see minor communication gap and we are heading in the right direction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
