nsivabalan commented on code in PR #12164:
URL: https://github.com/apache/hudi/pull/12164#discussion_r1952933035
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -913,11 +913,8 @@ public String startCommit(String actionType,
HoodieTableMetaClient metaClient) {
executeUsingTxnManager(Option.empty(), () -> tryUpgrade(metaClient,
Option.empty()));
}
- CleanerUtils.rollbackFailedWrites(config.getFailedWritesCleanPolicy(),
- HoodieTimeline.COMMIT_ACTION, () ->
tableServiceClient.rollbackFailedWrites());
Review Comment:
I am not sure if we can remove this.
new instant creation could differ based on table version. So, we can flip
the ordering here.
also, can you check latest master. Is there a repeated call to
executeUsingTxnManager and rollbackFailedWrites ?
I don't see that. can you help me locate.
I def agree that there are lot of similarly named methods. we can try to fix
those for sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
