vinishjail97 commented on code in PR #12813:
URL: https://github.com/apache/hudi/pull/12813#discussion_r1960808247
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieErrorTableConfig.java:
##########
@@ -84,6 +84,11 @@ public class HoodieErrorTableConfig extends HoodieConfig {
.defaultValue(ErrorWriteFailureStrategy.ROLLBACK_COMMIT.name())
.withDocumentation("The config specifies the failure strategy if error
table write fails. "
+ "Use one of - " +
Arrays.toString(ErrorWriteFailureStrategy.values()));
+ public static final ConfigProperty<Boolean>
ENABLE_ERROR_TABLE_WRITE_UNIFICATION = ConfigProperty
Review Comment:
The error table write implementation can't do a union if they implement the
`upsertAndCommit` method so still need to support it behind a feature flag to
avoid breaking things for existing users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
