yihua commented on code in PR #12873:
URL: https://github.com/apache/hudi/pull/12873#discussion_r1969008234
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1510,12 +1510,20 @@ public void performTableServices(Option<String>
inFlightInstantTimestamp, boolea
allTableServicesExecutedSuccessfullyOrSkipped = false;
throw e;
} finally {
+ String tableName = writeClient.getConfig().getTableName();
Review Comment:
Should the table name be renamed to have a suffix of `_mdt` based on the
data table name so that the metric does not clash with the data table metrics
and is easier to interpret?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1510,12 +1510,20 @@ public void performTableServices(Option<String>
inFlightInstantTimestamp, boolea
allTableServicesExecutedSuccessfullyOrSkipped = false;
throw e;
} finally {
+ String tableName = writeClient.getConfig().getTableName();
+ boolean tableNameExists = StringUtils.nonEmpty(tableName);
+ String executionDurationMetricName = tableNameExists
+ ? String.format("%s.%s", tableName,
HoodieMetadataMetrics.TABLE_SERVICE_EXECUTION_DURATION)
Review Comment:
Does other metric reporter require table name as the first component in the
metric name (is it compatible to all metric reporters)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
