TheR1sing3un commented on code in PR #12925:
URL: https://github.com/apache/hudi/pull/12925#discussion_r1984948370
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/HoodieSparkFileGroupReaderBasedMergeHandle.java:
##########
@@ -191,7 +191,7 @@ public void write() {
writeSchemaWithMetaFields,
internalSchemaOption,
hoodieTable.getMetaClient(),
- hoodieTable.getMetaClient().getTableConfig().getProps(),
+ config.getProps(),
Review Comment:
> We may want to merge the table config and write config and then pass in
the merged props, because the write configs corresponding to the table configs,
such as record key and precombine fields may not be required. In that case, the
table config is used. Also, the file group reader prefers table config.
Agree. I have updated the code, please have a look! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
