[ 
https://issues.apache.org/jira/browse/HUDI-9042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938667#comment-17938667
 ] 

Geser Dugarov edited comment on HUDI-9042 at 3/26/25 5:29 PM:
--------------------------------------------------------------

`CustomAvroKeyGenerator` hasn't been supported in the master branch initially:

[https://github.com/apache/hudi/pull/12796#discussion_r1960832413]

And users need in in key generator of this type is questionable. So under this 
task, I propose to fix only broken support by `RowDataKeyGen` of `DATE_STRING` 
case from `TimestampBasedAvroKeyGenerator`, and revisit 
`CustomAvroKeyGenerator` separately for all engines.


was (Author: JIRAUSER301110):
`CustomAvroKeyGenerator` hasn't been supported in the master branch initially:

[https://github.com/apache/hudi/pull/12796#discussion_r1960832413]

And users need in in key generator of this type is questionable. So under this 
task, I propose to fix only `DATE_STRING` broken case for 
`TimestampBasedAvroKeyGenerator` and revisit `CustomAvroKeyGenerator` 
separately, and for all engines.

> `RowDataKeyGen` doesn't support all available key generators
> ------------------------------------------------------------
>
>                 Key: HUDI-9042
>                 URL: https://issues.apache.org/jira/browse/HUDI-9042
>             Project: Apache Hudi
>          Issue Type: Task
>            Reporter: Geser Dugarov
>            Assignee: Geser Dugarov
>            Priority: Major
>              Labels: pull-request-available
>
> `RowDataKeyGen`:
> 1. doesn't support `CustomAvroKeyGenerator`,
> 2. doesn't allow to process case, when partition column is string, and we set 
> key generator as:
> {noformat}
> 'hoodie.datasource.write.keygenerator.class'='org.apache.hudi.keygen.TimestampBasedAvroKeyGenerator',
> 'hoodie.keygen.timebased.timestamp.type' = 'DATE_STRING',
> 'hoodie.keygen.timebased.input.dateformat' = 'yyyy-MM-dd HH:mm:ss',
> 'hoodie.keygen.timebased.output.dateformat' = 'yyyy-MM-dd'
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to