[GitHub] [hudi] lw309637554 commented on a change in pull request #2136: [HUDI-37] Persist the HoodieIndex type in the hoodie.properties file

[GitBox]

lw309637554 commented on a change in pull request #2136:
URL: https://github.com/apache/hudi/pull/2136#discussion_r511574134



##########
File path: 
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/AbstractUpgradeDowngrade.java
##########
@@ -132,6 +134,8 @@ protected void run(HoodieTableVersion toVersion, String 
instantTime) throws IOEx
   }
 
   private void createUpdatedFile(Properties props) throws IOException {
+    DefaultHoodieConfig.setDefaultOnCondition(props, 
!props.containsKey(HoodieIndexConfig.INDEX_TYPE_PROP),

Review comment:
       yes, but have case such that :
   before the upgrade, there is no index type in hoodie properties, can persist 
the index type as DEFAULT_INDEX_TYPE in hoodie properties after upgrade




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org