vinishjail97 commented on code in PR #13216: URL: https://github.com/apache/hudi/pull/13216#discussion_r2061032439
########## hudi-common/src/main/java/org/apache/hudi/common/PluggableTableFormat.java: ########## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common; + +import org.apache.hudi.avro.model.HoodieCleanMetadata; +import org.apache.hudi.common.engine.HoodieEngineContext; +import org.apache.hudi.common.model.HoodieCommitMetadata; +import org.apache.hudi.common.table.HoodieTableMetaClient; +import org.apache.hudi.common.table.timeline.HoodieInstant; +import org.apache.hudi.common.table.timeline.TimelineFactory; +import org.apache.hudi.common.table.view.FileSystemViewManager; + +import java.io.Serializable; +import java.util.List; + +/** + * External Table Format needs to implement this interface + */ +public interface PluggableTableFormat extends Serializable { + + /** + * Called just after marking the write action as complete in hoodie timeline. Implementation expected to save additional state needed in + * extraMetadata. + * + * @param commitMetadata HoodieCommitMetadata for commit or clustering action. + * @param completedInstant completed instant in hoodie timeline + * @param engineContext engine context used for execution - local,spark or flink etc. + * @param metaClient metaClient from HoodieTable. + * @param viewManager viewManager from HoodieTable. + */ + + default void commit( + HoodieCommitMetadata commitMetadata, + HoodieInstant completedInstant, + HoodieEngineContext engineContext, + HoodieTableMetaClient metaClient, + FileSystemViewManager viewManager) { Review Comment: HoodieWriteClient creates a HoodieTable object before starting any write operation, what do you think of passing HoodieTable object in this interface? HoodieTable can be used to access all three fields. ``` HoodieEngineContext engineContext, HoodieTableMetaClient metaClient, FileSystemViewManager viewManager ``` ########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java: ########## @@ -181,7 +181,7 @@ public HoodieTableVersion version() { protected abstract HoodieIndex<?, ?> getIndex(HoodieWriteConfig config, HoodieEngineContext context); - private synchronized FileSystemViewManager getViewManager() { + public synchronized FileSystemViewManager getViewManager() { Review Comment: Was this `private synchronized` for any historical reason? ########## hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/StreamSync.java: ########## @@ -453,6 +454,7 @@ HoodieTableMetaClient initializeEmptyTable(HoodieTableMetaClient.TableBuilder ta Boolean.parseBoolean(HIVE_STYLE_PARTITIONING_ENABLE.defaultValue()))) .setUrlEncodePartitioning(props.getBoolean(URL_ENCODE_PARTITIONING.key(), Boolean.parseBoolean(URL_ENCODE_PARTITIONING.defaultValue()))) + .setPluggableTableFormatClass(props.getProperty(HoodieTableConfig.SUPPLEMENTARY_TABLE_FORMAT_CLASS_NAME.key(), HudiPluggableTableFormat.class.getName())) Review Comment: There are other spark writers apart from deltastreamer/spark-sql, planning to support them as well in the future? ########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/CopyOnWriteRollbackActionExecutor.java: ########## @@ -70,6 +70,18 @@ protected List<HoodieRollbackStat> executeRollback(HoodieRollbackPlan hoodieRoll resolvedInstant = activeTimeline.revertToInflight(instantToRollback); // reload meta-client to reflect latest timeline status table.getMetaClient().reloadActiveTimeline(); + // rollback instant in supplementary table format as well. Review Comment: Unit tests for this rollback logic? ########## hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataFactory.java: ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.metadata; + +import org.apache.hudi.common.config.HoodieMetadataConfig; +import org.apache.hudi.common.engine.HoodieEngineContext; +import org.apache.hudi.storage.HoodieStorage; + +public class HoodieTableMetadataFactory extends BaseHoodieTableMetadataFactory { + + @Override + public HoodieTableMetadata create(HoodieEngineContext engineContext, HoodieStorage storage, Review Comment: If we are not calling create in this PR should we move this factory to the next PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
