the-other-tim-brown opened a new pull request, #13242:
URL: https://github.com/apache/hudi/pull/13242
### Change Logs
- Adds a class `EngineBasedMerger` that handles the merging logic that was
duplicated in the FileGroupReader code. This class serves as an optimal way to
perform the commit and event time ordering based merge without constructing
HoodieRecords which reduces overhead.
- Standardizes how deletes are translated into HoodieRecords
- Reduces duplicate code in FileGroupRecordBuffer implementations to ensure
consistent behavior
### Impact
- Makes the merging logic easier to test and consistent when merging two log
records vs a log and base file record
- Reduces maintenance overhead by deduping the code
### Risk level (write none, low medium or high below)
Low, increases coverage and fixes some minor issues in the merge logic
### Documentation Update
_Describe any necessary documentation update if there is any new feature,
config, or user-facing change. If not, put "none"._
- _The config description must be updated if new configs are added or the
default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website.
Please create a Jira ticket, attach the
ticket number here and follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website) to
make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
