nsivabalan commented on a change in pull request #2206: URL: https://github.com/apache/hudi/pull/2206#discussion_r519503664
########## File path: hudi-spark/src/main/java/org/apache/hudi/PreCombineRow.java ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi; + +import org.apache.spark.sql.Row; + +import java.io.Serializable; + +/** + * Interface used to preCombine two Spark sql Rows. + */ +public interface PreCombineRow extends Serializable { Review comment: yeah, no idea why the reduce fn is giving an issue. Casting to comprable works. But we might have to support user defined preCombine as well right. Also, need to think about complex fields and not just simple fields. ``` groupedDataset.reduceGroups((ReduceFunction<Row>) (v1, v2) -> { int compareVal = ((Comparable) v1.get(fieldIndex)).compareTo(v2.get(fieldIndex)); if (compareVal >= 0) { return v1; } else { return v2; } }); ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
