yihua commented on code in PR #13223:
URL: https://github.com/apache/hudi/pull/13223#discussion_r2076081920
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/SparkFileFormatInternalRowReaderContext.scala:
##########
@@ -165,10 +172,10 @@ class
SparkFileFormatInternalRowReaderContext(parquetFileReader: SparkParquetRea
//If we need to do position based merging with log files we will leave
the row index column at the end
val dataProjection = if (getHasLogFiles &&
getShouldMergeUseRecordPosition) {
- getIdentityProjection
+ getBootstrapProjection(dataRequiredSchema, dataRequiredSchema,
partitionFields, partitionValues)
} else {
- projectRecord(dataRequiredSchema,
- HoodieAvroUtils.removeFields(dataRequiredSchema, rowIndexColumn))
+ getBootstrapProjection(dataRequiredSchema,
+ HoodieAvroUtils.removeFields(dataRequiredSchema, rowIndexColumn),
partitionFields, partitionValues)
}
Review Comment:
Yes, that should be possible; based on my previous testing, the missing part
in directly using file group reader for bootstrap support in compaction and
clustering in Spark is the way of parsing the partition path into partition
field value, i.e., it was not supported in the file group reader. Now this PR
fixes that.
Cleanup of this part is good enough for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
