danny0405 commented on code in PR #13242:
URL: https://github.com/apache/hudi/pull/13242#discussion_r2078759123
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -148,27 +148,28 @@ public HoodieFileGroupReader(HoodieReaderContext<T>
readerContext, HoodieStorage
/**
* Initialize correct record buffer
*/
- private static FileGroupRecordBuffer getRecordBuffer(HoodieReaderContext
readerContext,
- HoodieTableMetaClient
hoodieTableMetaClient,
- RecordMergeMode
recordMergeMode,
- TypedProperties props,
- Option<HoodieBaseFile>
baseFileOption,
- boolean hasNoLogFiles,
- boolean isSkipMerge,
- boolean
shouldUseRecordPosition,
- HoodieReadStats
readStats) {
+ private static <T> FileGroupRecordBuffer<T>
getRecordBuffer(HoodieReaderContext<T> readerContext,
+
HoodieTableMetaClient hoodieTableMetaClient,
+ RecordMergeMode
recordMergeMode,
+ TypedProperties
props,
+
Option<HoodieBaseFile> baseFileOption,
+ boolean
hasNoLogFiles,
+ boolean
isSkipMerge,
+ boolean
shouldUseRecordPosition,
+ HoodieReadStats
readStats) {
+ EngineBasedMerger<T> merger = new EngineBasedMerger<>(readerContext,
recordMergeMode, hoodieTableMetaClient.getTableConfig(), props);
if (hasNoLogFiles) {
return null;
} else if (isSkipMerge) {
return new UnmergedFileGroupRecordBuffer<>(
- readerContext, hoodieTableMetaClient, recordMergeMode,
Option.empty(), Option.empty(), props, readStats);
+ readerContext, hoodieTableMetaClient, recordMergeMode,
Option.empty(), Option.empty(), props, readStats, merger);
Review Comment:
+1 to @jonvex , why can't we just initialze the `merger` inside each
specific record buffer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
