yihua commented on code in PR #13261:
URL: https://github.com/apache/hudi/pull/13261#discussion_r2093986489
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1403,7 +1403,7 @@ protected void commitInternal(String instantTime,
Map<String, HoodieData<HoodieR
metadataMetaClient.reloadActiveTimeline();
}
- writeClient.startCommitWithTime(instantTime);
+ writeClient.startCommitForMetadataTable(instantTime,
HoodieActiveTimeline.DELTA_COMMIT_ACTION);
Review Comment:
Let's create a separate JIRA to revisit the `metaClient` usage here.
Ideally `metadataMetaClient` should be reused, which has been refreshed before
this statement. `startCommitWithTime` creates a new meta client inside; not
sure if that's intentional in the case of MDT writer.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1403,7 +1403,7 @@ protected void commitInternal(String instantTime,
Map<String, HoodieData<HoodieR
metadataMetaClient.reloadActiveTimeline();
}
- writeClient.startCommitWithTime(instantTime);
+ writeClient.startCommitForMetadataTable(instantTime,
HoodieActiveTimeline.DELTA_COMMIT_ACTION);
Review Comment:
cc @nsivabalan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
