danny0405 commented on code in PR #13261:
URL: https://github.com/apache/hudi/pull/13261#discussion_r2094678274
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -944,13 +953,25 @@ public void startCommitWithTime(String instantTime) {
}
/**
- * Completes a new commit time for a write operation
(insert/update/delete/insert_overwrite/insert_overwrite_table) with specified
action.
+ * Provides a new commit at the specified time with the provided action type.
+ * This is only for testing purposes to setup particular sequences of
commits.
+ * @param instantTime the commit start time
+ * @param actionType the type of commit
*/
- public void startCommitWithTime(String instantTime, String actionType) {
+ @VisibleForTesting
+ void startCommitWithTime(String instantTime, String actionType) {
Review Comment:
should we also deprecate `startCommitWithTime(String instantTime)` ? It
looks like it's only been used by tests already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
