yihua commented on code in PR #13261:
URL: https://github.com/apache/hudi/pull/13261#discussion_r2099037085
##########
hudi-spark-datasource/hudi-spark-common/src/main/java/org/apache/hudi/commit/BaseDatasetBulkInsertCommitActionExecutor.java:
##########
@@ -56,20 +56,19 @@ public abstract class
BaseDatasetBulkInsertCommitActionExecutor implements Seria
protected final transient HoodieWriteConfig writeConfig;
protected final transient SparkRDDWriteClient writeClient;
- protected final String instantTime;
+ protected String instantTime;
protected HoodieTable table;
public BaseDatasetBulkInsertCommitActionExecutor(HoodieWriteConfig config,
- SparkRDDWriteClient
writeClient,
- String instantTime) {
+ SparkRDDWriteClient
writeClient) {
this.writeConfig = config;
this.writeClient = writeClient;
- this.instantTime = instantTime;
}
protected void preExecute() {
+ instantTime = writeClient.startCommit(getCommitActionType());
+ table = writeClient.initTable(getWriteOperationType(),
Option.ofNullable(instantTime));
Review Comment:
Previously `writeClient.initTable` happens before `startCommitWithTime`; the
order now (`initTable` after `startCommit`) makes more sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
