linliu-code commented on code in PR #13334:
URL: https://github.com/apache/hudi/pull/13334#discussion_r2110782852
##########
hudi-common/src/main/java/org/apache/hudi/common/util/HoodieRecordUtils.java:
##########
@@ -85,11 +88,21 @@ public static HoodieRecordMerger createRecordMerger(String
basePath, EngineType
}
public static Option<HoodieRecordMerger> createValidRecordMerger(EngineType
engineType,
- String
mergerImpls, String recordMergerStrategy) {
- if
(recordMergerStrategy.equals(HoodieRecordMerger.PAYLOAD_BASED_MERGE_STRATEGY_UUID))
{
- return Option.of(HoodieAvroRecordMerger.INSTANCE);
+ String
mergerImpls,
+ String
recordMergerStrategy) {
+ switch (recordMergerStrategy) {
+ case HoodieRecordMerger.FIRST_VALUE_MERGE_STRATEGY_UUID:
Review Comment:
My understanding is:
We don't change the overall process of specifying the merger.
What we change is: if the user specifies a builtin payload class, it will be
translated internally into its corresponding merger class.
If the user already specifies the merger class, it should be the same
process as of 1.0.2.
I think I need to add a functional test to illustrate the process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
