yihua commented on code in PR #12964:
URL: https://github.com/apache/hudi/pull/12964#discussion_r2116599978
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/io/hadoop/TestHoodieHFileReaderWriter.java:
##########
@@ -60,7 +60,6 @@ protected HoodieAvroHFileReaderImplBase
createHFileReader(HoodieStorage storage,
protected void verifyHFileReader(byte[] content,
String hfileName,
boolean mayUseDefaultComparator,
- Class<?> expectedComparatorClazz,
Review Comment:
Yes, String comparison is good enough.
##########
pom.xml:
##########
@@ -1875,6 +1845,11 @@
<artifactId>mbknor-jackson-jsonschema_${scala.binary.version}</artifactId>
<version>1.0.39</version>
</dependency>
+ <dependency>
+ <groupId>javax.validation</groupId>
+ <artifactId>validation-api</artifactId>
+ <version>2.0.1.Final</version>
+ </dependency>
Review Comment:
I see this dependency is no longer used which should be good.
##########
hudi-sync/hudi-datahub-sync/pom.xml:
##########
@@ -93,6 +93,13 @@
<scope>compile</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-common</artifactId>
+ <version>${hadoop.version}</version>
+ <scope>compile</scope>
+ </dependency>
Review Comment:
Sg
##########
hudi-client/hudi-java-client/pom.xml:
##########
@@ -126,6 +126,13 @@
<version>${hive.version}</version>
<scope>test</scope>
</dependency>
+
+ <!-- Hadoop - Test -->
Review Comment:
Check `hudi-examples/hudi-examples-k8s/pom.xml`:
```
<exclude>org.apache.hbase.thirdparty:*</exclude>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
