the-other-tim-brown commented on code in PR #13411:
URL: https://github.com/apache/hudi/pull/13411#discussion_r2139125531
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataPayload.java:
##########
@@ -376,19 +377,24 @@ public Option<IndexedRecord>
combineAndGetUpdateValue(IndexedRecord oldRecord, S
}
@Override
- public Option<IndexedRecord> getInsertValue(Schema schemaIgnored, Properties
propertiesIgnored) throws IOException {
+ public Option<IndexedRecord> getInsertValue(Schema schema, Properties
propertiesIgnored) throws IOException {
if (key == null || this.isDeletedRecord) {
return Option.empty();
}
HoodieMetadataRecord record = new HoodieMetadataRecord(key, type,
filesystemMetadata, bloomFilterMetadata,
columnStatMetadata, recordIndexMetadata, secondaryIndexMetadata);
- return Option.of(record);
+ if (schema == null ||
HoodieMetadataRecord.getClassSchema().equals(schema)) {
+ // If the schema is same or none is provided, we can return the record
directly
+ return Option.of(record);
+ } else {
+ return Option.of(rewriteRecord(record, schema));
+ }
}
@Override
public Option<IndexedRecord> getInsertValue(Schema schema) throws
IOException {
- return getInsertValue(schema, new Properties());
+ return getInsertValue(schema, null);
Review Comment:
I can use that but it is actually a mutable, shared instance. That means if
any user modifies the properties, they will get leaked to other sites. The code
needs to be fixed to make that instance immutable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
