danny0405 commented on code in PR #13540:
URL: https://github.com/apache/hudi/pull/13540#discussion_r2209043144
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/PartialUpdateStrategy.java:
##########
@@ -45,56 +46,91 @@ public class PartialUpdateStrategy<T> {
private final HoodieReaderContext<T> readerContext;
private final PartialUpdateMode partialUpdateMode;
private final Map<String, String> mergeProperties;
+ private final PartialMergingUtils<T> partialMergingUtils;
public PartialUpdateStrategy(HoodieReaderContext<T> readerContext,
PartialUpdateMode partialUpdateMode,
TypedProperties props) {
this.readerContext = readerContext;
this.partialUpdateMode = partialUpdateMode;
this.mergeProperties = parseMergeProperties(props);
+ if (partialUpdateMode == PartialUpdateMode.KEEP_VALUES) {
Review Comment:
It seems like the `PartialUpdateMode.KEEP_VALUES` mode is kind of orthoganal
to existing partial merging logic, is it possible we add another two partial
update `BufferedRecordMerger`s and also a new `#partialMerge` method here so
make the logic more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
