wangxianghu commented on a change in pull request #2278:
URL: https://github.com/apache/hudi/pull/2278#discussion_r532205088
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java
##########
@@ -278,5 +299,16 @@ public HoodieIndexConfig build() {
HoodieIndex.IndexType.valueOf(props.getProperty(INDEX_TYPE_PROP));
return config;
}
+
+ private String getDefaultIndexType(EngineType engineType) {
+ switch (engineType) {
Review comment:
> Are there other configurations that are different in different
engines, and if there are many, are they easy to implement in this way?
Currently, I recognized this only as I am working on flink index.
I think it is simple, just add a check step before initialized it.
this way should be ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
