danny0405 commented on code in PR #13556:
URL: https://github.com/apache/hudi/pull/13556#discussion_r2217527827
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/FileGroupReaderBasedAppendHandle.java:
##########
@@ -114,6 +115,7 @@ public List<WriteStatus> close() {
if (writeStatus.getStat().getRuntimeStats() != null) {
writeStatus.getStat().getRuntimeStats().setTotalScanTime(readStats.getTotalLogReadTimeMs());
}
+ writeStatus.getStat().setPrevCommit(operation.getBaseInstantTime());
Review Comment:
it could be the first delta commit time if there is no base file, for log
compaction, this seems incorrect, current only cdc read relies on the
prevCommit for resolving dependencies, we might ignore it for log compaction
because query base instant time per file-split is very costly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
