yihua commented on code in PR #13602:
URL: https://github.com/apache/hudi/pull/13602#discussion_r2226823306
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedTableMetadata.java:
##########
@@ -133,55 +133,55 @@ public void testTableOperations(boolean reuseReaders, int
tableVersion) throws E
@ParameterizedTest
@CsvSource({"true,6", "true,8", "false,6", "false,8"})
public void testMultiReaderForHoodieBackedTableMetadata(boolean reuse, int
tableVersion) throws Exception {
- final int taskNumber = 3;
+ final int taskNumber = 6;
Review Comment:
So we'd like to pressure test threading safety, should this be increased to
a higher number, e.g., 20, assuming with reader reuse, the method calls to
`tableMetadata` are faster (accounting for future improvement on HFile reader
so this test stands)?
##########
hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroReaderContext.java:
##########
@@ -69,15 +70,26 @@
*/
public class HoodieAvroReaderContext extends
HoodieReaderContext<IndexedRecord> {
private final String payloadClass;
+ private final Map<StoragePath, HoodieAvroFileReader> reusableFileReaders;
Review Comment:
Is the caller responsible to close the readers in the map? Should that be
called out in javadocs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
