jonvex commented on code in PR #13603: URL: https://github.com/apache/hudi/pull/13603#discussion_r2232301605
########## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/index/SparkMetadataTablePartitionedRecordIndex.java: ########## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.index; + +import org.apache.hudi.common.data.HoodieData; +import org.apache.hudi.common.data.HoodieListData; +import org.apache.hudi.common.data.HoodiePairData; +import org.apache.hudi.common.engine.HoodieEngineContext; +import org.apache.hudi.common.model.FileSlice; +import org.apache.hudi.common.model.HoodieRecord; +import org.apache.hudi.common.model.HoodieRecordGlobalLocation; +import org.apache.hudi.common.util.Either; +import org.apache.hudi.common.util.HoodieDataUtils; +import org.apache.hudi.common.util.Option; +import org.apache.hudi.common.util.ValidationUtils; +import org.apache.hudi.common.util.collection.Pair; +import org.apache.hudi.config.HoodieWriteConfig; +import org.apache.hudi.data.HoodieJavaPairRDD; +import org.apache.hudi.data.HoodieJavaRDD; +import org.apache.hudi.metadata.HoodieTableMetadataUtil; +import org.apache.hudi.metadata.MetadataPartitionType; +import org.apache.hudi.metadata.BucketizedMetadataTableFileGroupIndexParser; +import org.apache.hudi.table.HoodieTable; + +import org.apache.spark.api.java.JavaRDD; +import org.apache.spark.api.java.function.PairFlatMapFunction; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.Iterator; +import java.util.List; +import java.util.Map; + +import scala.Tuple2; + +/** + * Index to be used with partitioned RLI. Queries the record index for tables with non-global record keys + */ +public class SparkMetadataTablePartitionedRecordIndex extends SparkMetadataTableRecordIndex { + + public SparkMetadataTablePartitionedRecordIndex(HoodieWriteConfig config) { + super(config); + } + + @Override + public boolean isGlobal() { + return false; + } + + @Override + protected HoodieIndex.IndexType getFallbackIndexType() { + return IndexType.SIMPLE; + } + + @Override + protected <R> HoodiePairData<String, HoodieRecordGlobalLocation> lookupRecords(HoodieData<HoodieRecord<R>> records, HoodieEngineContext context, + HoodieTable hoodieTable, Either<Integer, Map<String, Integer>> fileGroupSize) { + Map<String, Integer> fileGroupCountPerDataPartition = fileGroupSize.asRight(); + int numFileGroups = getTotalFileGroupCount(fileGroupSize); + Map<String, Integer> partitionOffsetIndexes = BucketizedMetadataTableFileGroupIndexParser.generatePartitionToBaseIndexOffsets(fileGroupCountPerDataPartition); + + // Partition the record keys to lookup such that each partition looks up one record index shard + JavaRDD<Pair<String, String>> partitionedKeyRDD = HoodieJavaRDD.getJavaRDD(records) + .filter(record -> partitionOffsetIndexes.containsKey(record.getPartitionPath())) + .map(record -> Pair.of(record.getPartitionPath(), record.getRecordKey())) + // get offset from partitionOffsetIndexes then add the hash of the key + .keyBy(k -> partitionOffsetIndexes.get(k.getLeft()) + HoodieTableMetadataUtil.mapRecordKeyToFileGroupIndex(k.getRight(), fileGroupCountPerDataPartition.get(k.getLeft()))) + .partitionBy(new PartitionIdPassthrough(numFileGroups)) + .map(t -> t._2); + ValidationUtils.checkState(partitionedKeyRDD.getNumPartitions() <= numFileGroups); + // Lookup the keys in the record index + return HoodieJavaPairRDD.of(partitionedKeyRDD.mapPartitionsToPair(new PartitionedRecordIndexFileGroupLookupFunction(hoodieTable))); + } + + @Override + protected Either<Integer, Map<String, Integer>> fetchFileGroupSize(HoodieTable hoodieTable) { + Map<String, Integer> partitionSizes = new HashMap<>(); + Map<String, List<FileSlice>> fileGroups = hoodieTable.getMetadataTable().getBucketizedFileGroupsForPartitionedRLI(MetadataPartitionType.RECORD_INDEX); + fileGroups.keySet().forEach(k -> partitionSizes.put(k, fileGroups.get(k).size())); + return Either.right(partitionSizes); + } + + @Override + protected int getTotalFileGroupCount(Either<Integer, Map<String, Integer>> fileGroupSize) { + return BucketizedMetadataTableFileGroupIndexParser.calculateNumberOfFileGroups(fileGroupSize.asRight()); + } + + @Override + protected boolean shouldUpdatePartitionPath(HoodieTable hoodieTable) { + return false; + } + + /** + * Function that lookups a list of keys in a single shard of the record index + */ + private static class PartitionedRecordIndexFileGroupLookupFunction implements PairFlatMapFunction<Iterator<Pair<String,String>>, String, HoodieRecordGlobalLocation> { + private final HoodieTable hoodieTable; + + public PartitionedRecordIndexFileGroupLookupFunction(HoodieTable hoodieTable) { + this.hoodieTable = hoodieTable; + } + + @Override + public Iterator<Tuple2<String, HoodieRecordGlobalLocation>> call(Iterator<Pair<String, String>> partitionPathRecordKeyIterator) throws Exception { + //Needs to be final, so we must use 1 element array to store the value + final String[] partitionName = {null}; + List<String> keysToLookup = new ArrayList<>(); + partitionPathRecordKeyIterator.forEachRemaining(p -> { + keysToLookup.add(p.getRight()); + if (partitionName[0] == null) { + partitionName[0] = p.getLeft(); + } + }); + + // recordIndexInfo object only contains records that are present in record_index. + assert partitionName[0] != null || keysToLookup.isEmpty(); + Map<String, HoodieRecordGlobalLocation> recordIndexInfo = HoodieDataUtils.dedupeAndCollectAsMap( + hoodieTable.getMetadataTable().readRecordIndex(HoodieListData.eager(keysToLookup), Option.ofNullable(partitionName[0]))); Review Comment: good catch. will fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
