danny0405 commented on code in PR #13645:
URL: https://github.com/apache/hudi/pull/13645#discussion_r2242317934
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/BufferedRecordMergerFactory.java:
##########
@@ -332,12 +335,15 @@ public MergeResult<T> finalMerge(BufferedRecord<T>
olderRecord, BufferedRecord<T
* based on {@code CUSTOM} merge mode.
*/
private static class CustomRecordMerger<T> extends BaseCustomMerger<T> {
+ private final String[] orderingFields;
+
public CustomRecordMerger(
HoodieReaderContext<T> readerContext,
Option<HoodieRecordMerger> recordMerger,
Schema readerSchema,
TypedProperties props) {
super(readerContext, recordMerger, readerSchema, props);
+ this.orderingFields = ConfigUtils.getOrderingFields(props);
Review Comment:
`BufferedRecordMergerFactory.create` already got a orderingValues param that
we can use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
