yihua commented on code in PR #13669: URL: https://github.com/apache/hudi/pull/13669#discussion_r2249322638
########## hudi-spark-datasource/hudi-spark/src/test/resources/upgrade-downgrade-fixtures/mor-tables/hudi-v4-table.zip: ########## Review Comment: When I unzip the files I see `__MACOSX` folder and `*.crc` files under base path, partition paths, and metadata folder. They can be deleted when creating the zip file as they are not needed for testing. ########## hudi-spark-datasource/hudi-spark/src/test/resources/upgrade-downgrade-fixtures/mor-tables/hudi-v4-table.zip: ########## Review Comment: Is it possible to further reduce the table size to below 50KB per table? ########## .gitignore: ########## @@ -87,3 +87,6 @@ dependency-reduced-pom.xml hudi-integ-test/compose_env node_modules package-lock.json + +# Spark Binaries used for testing +hudi-spark-datasource/hudi-spark/src/test/resources/upgrade-downgrade-fixtures/spark-versions/ Review Comment: nit: new line at the end of the file ########## hudi-spark-datasource/hudi-spark/src/test/resources/upgrade-downgrade-fixtures/scala-templates/generate-fixture.scala: ########## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import org.apache.spark.sql.SaveMode +import org.apache.hudi.DataSourceWriteOptions._ +import spark.implicits._ + +val tableName = "${TABLE_NAME}" +val basePath = "${BASE_PATH}" + +// Create simple test data with consistent schema +val testData = Seq( + ("id1", "Alice", 1000L, "2023-01-01"), + ("id2", "Bob", 2000L, "2023-01-01"), + ("id3", "Charlie", 3000L, "2023-01-02"), + ("id4", "David", 4000L, "2023-01-02"), + ("id5", "Eve", 5000L, "2023-01-03") +) + +val df = testData.toDF("id", "name", "ts", "partition") + +// Write initial batch (creates base files) +df.write.format("hudi"). + option(PRECOMBINE_FIELD.key, "ts"). + option(RECORDKEY_FIELD.key, "id"). + option(PARTITIONPATH_FIELD.key, "partition"). + option("hoodie.table.name", tableName). + option("hoodie.datasource.write.table.type", "MERGE_ON_READ"). + option("hoodie.datasource.write.operation", "insert"). + mode(SaveMode.Overwrite). + save(basePath) + +println("Initial batch written") + +// Write update batch (creates log files) +val updateData = Seq( + ("id1", "Alice_Updated", 1001L, "2023-01-01"), + ("id2", "Bob_Updated", 2001L, "2023-01-01"), + ("id6", "Frank", 6000L, "2023-01-03") +) + +val updateDf = updateData.toDF("id", "name", "ts", "partition") + +updateDf.write.format("hudi"). + option(PRECOMBINE_FIELD.key, "ts"). + option(RECORDKEY_FIELD.key, "id"). + option(PARTITIONPATH_FIELD.key, "partition"). + option("hoodie.table.name", tableName). + option("hoodie.datasource.write.table.type", "MERGE_ON_READ"). + option("hoodie.datasource.write.operation", "upsert"). + mode(SaveMode.Append). + save(basePath) + +println("Update batch written") + +// Create one more insert to have multiple commits +val insertData = Seq( + ("id7", "Grace", 7000L, "2023-01-04"), + ("id8", "Henry", 8000L, "2023-01-04") +) + +val insertDf = insertData.toDF("id", "name", "ts", "partition") + +insertDf.write.format("hudi"). + option(PRECOMBINE_FIELD.key, "ts"). + option(RECORDKEY_FIELD.key, "id"). + option(PARTITIONPATH_FIELD.key, "partition"). + option("hoodie.table.name", tableName). + option("hoodie.datasource.write.table.type", "MERGE_ON_READ"). + option("hoodie.datasource.write.operation", "insert"). + mode(SaveMode.Append). + save(basePath) + +println("Additional insert written") +println(s"Fixture ${FIXTURE_NAME} generated successfully!") + +System.exit(0) Review Comment: nit: check all new files to make sure they have a new line at the end. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
