n3nash commented on a change in pull request #2301: URL: https://github.com/apache/hudi/pull/2301#discussion_r537926684
########## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java ########## @@ -460,7 +460,7 @@ protected void reconcileAgainstMarkers(HoodieEngineContext context, if (!invalidDataPaths.isEmpty()) { LOG.info("Removing duplicate data files created due to spark retries before committing. Paths=" + invalidDataPaths); Map<String, List<Pair<String, String>>> invalidPathsByPartition = invalidDataPaths.stream() - .map(dp -> Pair.of(new Path(dp).getParent().toString(), new Path(basePath, dp).toString())) + .map(dp -> Pair.of(new Path(basePath, dp).getParent().toString(), new Path(basePath, dp).toString())) Review comment: @bvaradar can we add a test for this ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org