yunchipang commented on code in PR #408: URL: https://github.com/apache/hudi-rs/pull/408#discussion_r2263390832
########## release/bump_version_in_main.sh: ########## @@ -81,23 +89,47 @@ fi echo "Current version of $crate: $current_version" -# Calculate new version -new_version=$(bump_version "$current_version" "$bump_type") +# Calculate new versions +new_rust_version=$(bump_version "$current_version" "$bump_type" "true") +new_cpp_version=$(bump_version "$current_version" "$bump_type" "false") -echo "New version for $crate: $new_version" +echo "New Rust version for $crate: $new_rust_version" +echo "New C++ version: $new_cpp_version" -# Update version using cargo set-version -cargo set-version "$new_version" --manifest-path "$crate/Cargo.toml" +# Update Rust version using cargo set-version +cargo set-version "$new_rust_version" --manifest-path "$crate/Cargo.toml" Review Comment: fixed! tested locally, PTAL if something like this is expected. thanks! <img width="596" height="338" alt="image" src="https://github.com/user-attachments/assets/945c575c-709c-435e-9dfc-a36dab77d7b0"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
