yihua commented on code in PR #13701:
URL: https://github.com/apache/hudi/pull/13701#discussion_r2268092506
##########
hudi-common/src/test/java/org/apache/hudi/metrics/TestMetricsReporterFactory.java:
##########
@@ -96,4 +96,3 @@ public IllegalTestMetricsReporter(Properties props,
MetricRegistry registry) {}
}
}
-
Review Comment:
Similarly on the test `metricsReporterFactoryShouldReturnCloudWatchReporter`
from #12969
##########
hudi-aws/src/test/java/org/apache/hudi/aws/metrics/cloudwatch/TestCloudWatchMetricsReporter.java:
##########
@@ -75,7 +94,7 @@ public void testReporterViaReporterFactory() {
} catch (Exception e) {
assertTrue(e.getCause() instanceof InvocationTargetException);
assertTrue(Arrays.stream(((InvocationTargetException)
e.getCause()).getTargetException().getStackTrace()).anyMatch(
- ste ->
ste.toString().contains("org.apache.hudi.aws.cloudwatch.CloudWatchReporter.getAmazonCloudWatchClient")));
+ ste ->
ste.toString().contains("org.apache.hudi.aws.metrics.cloudwatch.CloudWatchReporter.getAmazonCloudWatchClient")));
Review Comment:
Is `testCreateCloudWatchReporter` not added intentionally, compared to
#12969?
##########
hudi-client/hudi-client-common/pom.xml:
##########
@@ -48,17 +48,6 @@
<artifactId>hudi-io</artifactId>
<version>${project.version}</version>
</dependency>
- <dependency>
- <groupId>org.apache.hudi</groupId>
- <artifactId>hudi-hadoop-common</artifactId>
- <version>${project.version}</version>
- </dependency>
Review Comment:
Should this still be kept?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
