the-other-tim-brown commented on code in PR #13699:
URL: https://github.com/apache/hudi/pull/13699#discussion_r2273349834
##########
hudi-common/src/main/java/org/apache/hudi/common/engine/RecordContext.java:
##########
@@ -340,7 +356,7 @@ public boolean supportsParquetRowIndex() {
}
private SerializableBiFunction<T, Schema, String> metadataKeyExtractor() {
- return (record, schema) -> getValue(record, schema,
RECORD_KEY_METADATA_FIELD).toString();
+ return (record, schema) -> typeConverter.castToString(getValue(record,
schema, RECORD_KEY_METADATA_FIELD));
Review Comment:
This may not be needed anymore. There was a bug where someone updated the
BufferedRecord creation from HoodieRecord to read the values from the data
instead of from the HoodieKey so I was getting some NPEs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
