the-other-tim-brown commented on code in PR #13615:
URL: https://github.com/apache/hudi/pull/13615#discussion_r2274434475
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/FileGroupReaderSchemaHandler.java:
##########
@@ -186,14 +187,18 @@ private static String[]
getMandatoryFieldsForMerging(HoodieTableConfig cfg,
boolean
hasBuiltInDelete,
Option<Pair<String,
String>> customDeleteMarkerKeyAndValue,
boolean
hasInstantRange) {
- Triple<RecordMergeMode, String, String> mergingConfigs =
HoodieTableConfig.inferCorrectMergingBehavior(
- cfg.getRecordMergeMode(),
- cfg.getPayloadClass(),
- cfg.getRecordMergeStrategyId(),
- cfg.getPreCombineFieldsStr().orElse(null),
- cfg.getTableVersion());
-
- if (mergingConfigs.getLeft() == RecordMergeMode.CUSTOM) {
+ RecordMergeMode mergeMode = cfg.getRecordMergeMode();
+ if (cfg.getTableVersion().lesserThan(HoodieTableVersion.NINE)) {
Review Comment:
The expression payload should only be on the writer path which implies we
will use the writer schema as the requested schema and all fields will be
included
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
