cshuo commented on code in PR #13615:
URL: https://github.com/apache/hudi/pull/13615#discussion_r2276081503
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/utils/TestFlinkWriteClients.java:
##########
@@ -147,8 +147,8 @@ void testRecordMergeConfigForPartialUpdate(int
configOrdinal) throws Exception {
HoodieTableMetaClient metaClient = StreamerUtil.initTableIfNotExists(conf);
HoodieTableConfig tableConfig = metaClient.getTableConfig();
- assertThat(tableConfig.getRecordMergeMode(), is(RecordMergeMode.CUSTOM));
Review Comment:
@nsivabalan @linliu-code We can enable this test and update the expected
merge mode to `EVENT_TIME_ORDERING`, and expected strategy id to
`EVENT_TIME_BASED_MERGE_STRATEGY_UUID` directly, then the
`BufferedRecordMerger` inside filegroup reader based merge handle will swtich
to `EventTimePartialRecordMerger` accordingly, and this part is covered by
flink compaction tests, like `TestInputFormat#testCompactWithPartialUpdate`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
