yihua commented on code in PR #13615:
URL: https://github.com/apache/hudi/pull/13615#discussion_r2277567173
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java:
##########
@@ -403,7 +403,7 @@ public static void addFlinkCheckpointIdIntoMetaData(
* @return The correct merging behaviour: <merge_mode, payload_class,
merge_strategy_id>
*/
public static Triple<RecordMergeMode, String, String>
inferMergingBehavior(Configuration conf) {
- return HoodieTableConfig.inferCorrectMergingBehavior(
+ return HoodieTableConfig.inferMergingConfigsForWrites(
Review Comment:
To be revisited after COW merge handle change is merged to master.
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/utils/TestFlinkWriteClients.java:
##########
@@ -147,8 +147,8 @@ void testRecordMergeConfigForPartialUpdate(int
configOrdinal) throws Exception {
HoodieTableMetaClient metaClient = StreamerUtil.initTableIfNotExists(conf);
HoodieTableConfig tableConfig = metaClient.getTableConfig();
- assertThat(tableConfig.getRecordMergeMode(), is(RecordMergeMode.CUSTOM));
Review Comment:
@cshuo Thanks for the suggestion. Fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
