lokeshj1703 commented on code in PR #13727:
URL: https://github.com/apache/hudi/pull/13727#discussion_r2280446598
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:
##########
@@ -1031,9 +1031,6 @@ object DataSourceOptionsHelper {
if (!params.contains(DataSourceWriteOptions.KEYGENERATOR_CLASS_NAME.key())
&& tableConfig.getKeyGeneratorClassName != null) {
missingWriteConfigs ++=
Map(DataSourceWriteOptions.KEYGENERATOR_CLASS_NAME.key() ->
tableConfig.getKeyGeneratorClassName)
}
- if (!params.contains(HoodieWriteConfig.PRECOMBINE_FIELD_NAME.key()) &&
tableConfig.getPreCombineFieldsStr.isPresent) {
- missingWriteConfigs ++= Map(HoodieWriteConfig.PRECOMBINE_FIELD_NAME.key
-> tableConfig.getPreCombineFieldsStr.orElse(null))
- }
Review Comment:
There was one issue which I was facing. Basically when precombine config is
not configured, we add it using table config.
Write config is therefore pointing to older table config but the table
config is updated to newer config after upgrade. In order to avoid such a
scenario removed addition of write config here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
