rahil-c commented on PR #13736: URL: https://github.com/apache/hudi/pull/13736#issuecomment-3212111891
@vamshikrishnakyatham Now that we have merged this PR: https://github.com/apache/hudi/commit/e11ee97662effb8cc71a318531d2362a8e5784a9 can you rebase the current PR on master in order to reduce the diff to make it easier for review. For the most part I think the complexity is in the `HoodieProcedureFilterUtils`, thanks for adding all these functions, types, etc in order to make this filter feature robust. My only concern is that we would likely need to have tests in order to ensure all these cases are covered (thanks for adding an intial set of tests on this pr). I think for any tests that were not added maybe you can file another JIRA to revisit in future? @yihua @jonvex @Davis-Zhang-Onehouse Im wondering if someone more familiar on spark side can also take a pass at this pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
