yihua commented on code in PR #13726:
URL: https://github.com/apache/hudi/pull/13726#discussion_r2294892303
##########
hudi-client/hudi-java-client/src/test/java/org/apache/hudi/table/action/commit/TestJavaCopyOnWriteActionExecutor.java:
##########
@@ -139,22 +138,10 @@ public void testUpdateRecords() throws Exception {
String partitionPath = "2016/01/31";
// Get some records belong to the same partition (2016/01/31)
- String recordStr1 =
"{\"_row_key\":\"8eb5b87a-1feh-4edd-87b4-6ec96dc405a0\","
- + "\"time\":\"2016-01-31T03:16:41.415Z\",\"number\":12}";
- String recordStr2 =
"{\"_row_key\":\"8eb5b87b-1feu-4edd-87b4-6ec96dc405a0\","
- + "\"time\":\"2016-01-31T03:20:41.415Z\",\"number\":100}";
- String recordStr3 =
"{\"_row_key\":\"8eb5b87c-1fej-4edd-87b4-6ec96dc405a0\","
- + "\"time\":\"2016-01-31T03:16:41.415Z\",\"number\":15}";
- String recordStr4 =
"{\"_row_key\":\"8eb5b87d-1fej-4edd-87b4-6ec96dc405a0\","
- + "\"time\":\"2016-01-31T03:16:41.415Z\",\"number\":51}";
-
List<HoodieRecord> records = new ArrayList<>();
- RawTripTestPayload rowChange1 = new RawTripTestPayload(recordStr1);
- records.add(new HoodieAvroRecord(new HoodieKey(rowChange1.getRowKey(),
rowChange1.getPartitionPath()), rowChange1));
- RawTripTestPayload rowChange2 = new RawTripTestPayload(recordStr2);
- records.add(new HoodieAvroRecord(new HoodieKey(rowChange2.getRowKey(),
rowChange2.getPartitionPath()), rowChange2));
- RawTripTestPayload rowChange3 = new RawTripTestPayload(recordStr3);
- records.add(new HoodieAvroRecord(new HoodieKey(rowChange3.getRowKey(),
rowChange3.getPartitionPath()), rowChange3));
+ records.add(createSimpleRecord("8eb5b87a-1feh-4edd-87b4-6ec96dc405a0",
"2016-01-31T03:16:41.415Z", 12));
+ records.add(createSimpleRecord("8eb5b87b-1feu-4edd-87b4-6ec96dc405a0",
"2016-01-31T03:16:41.415Z", 100));
Review Comment:
record2 has `2016-01-31T03:20:41.415Z` as the time before; not sure if
that'll change the test behavior.
##########
hudi-client/hudi-java-client/src/test/java/org/apache/hudi/table/action/commit/TestJavaCopyOnWriteActionExecutor.java:
##########
@@ -471,20 +434,10 @@ public void testDeleteRecords() throws Exception {
String partitionPath = "2022/04/09";
// Get some records belong to the same partition (2016/01/31)
- String recordStr1 =
"{\"_row_key\":\"8eb5b87a-1feh-4edd-87b4-6ec96dc405a0\","
- + "\"time\":\"2022-04-09T03:16:41.415Z\",\"number\":1}";
- String recordStr2 =
"{\"_row_key\":\"8eb5b87b-1feu-4edd-87b4-6ec96dc405a0\","
- + "\"time\":\"2022-04-09T03:20:41.415Z\",\"number\":2}";
- String recordStr3 =
"{\"_row_key\":\"8eb5b87c-1fej-4edd-87b4-6ec96dc405a0\","
- + "\"time\":\"2022-04-09T03:16:41.415Z\",\"number\":3}";
-
List<HoodieRecord> records = new ArrayList<>();
- RawTripTestPayload rowChange1 = new RawTripTestPayload(recordStr1);
- records.add(new HoodieAvroRecord(new HoodieKey(rowChange1.getRowKey(),
rowChange1.getPartitionPath()), rowChange1));
- RawTripTestPayload rowChange2 = new RawTripTestPayload(recordStr2);
- records.add(new HoodieAvroRecord(new HoodieKey(rowChange2.getRowKey(),
rowChange2.getPartitionPath()), rowChange2));
- RawTripTestPayload rowChange3 = new RawTripTestPayload(recordStr3);
- records.add(new HoodieAvroRecord(new HoodieKey(rowChange3.getRowKey(),
rowChange3.getPartitionPath()), rowChange3));
+ records.add(createSimpleRecord("8eb5b87a-1feh-4edd-87b4-6ec96dc405a0",
"2022-04-09T03:16:41.415Z", 1));
+ records.add(createSimpleRecord("8eb5b87b-1feu-4edd-87b4-6ec96dc405a0",
"2022-04-09T03:20:41.415", 2));
Review Comment:
nit:
```suggestion
records.add(createSimpleRecord("8eb5b87b-1feu-4edd-87b4-6ec96dc405a0",
"2022-04-09T03:20:41.415Z", 2));
```
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/TestHoodieDefaultMergeHandle.java:
##########
@@ -199,7 +202,9 @@ public void
testUpsertsForMultipleRecordsInSameFile(ExternalSpillableMap.DiskMap
// This exists in 001 and should be updated
HoodieRecord sameAsRecord2 =
dataGen.generateUpdateRecord(record2.getKey(), newCommitTime);
updateRecords.add(sameAsRecord2);
- JavaRDD<HoodieRecord> updateRecordsRDD = jsc.parallelize(updateRecords,
1);
+ JavaRDD<HoodieRecord> updateRecordsRDD =
jsc.parallelize(updateRecords.stream()
+ .map(record -> new HoodieAvroRecord<>(record.getKey(), new
HoodieAvroPayload(Option.of((GenericRecord) record.getData()))))
Review Comment:
Should this use `HoodieAvroIndexedRecord` or this one intends to test with
`HoodieAvroPayload`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
