tiennguyen-onehouse commented on code in PR #13861:
URL: https://github.com/apache/hudi/pull/13861#discussion_r2366836265


##########
hudi-sync/hudi-datahub-sync/src/main/java/org/apache/hudi/sync/datahub/config/DataHubSyncConfig.java:
##########
@@ -136,6 +136,42 @@ public class DataHubSyncConfig extends HoodieSyncConfig {
       .markAdvanced()
       .withDocumentation("The name of the destination table that we should 
sync the hudi table to.");
 
+  // TLS Configuration Properties
+  public static final ConfigProperty<String> 
META_SYNC_DATAHUB_TLS_CA_CERT_PATH = ConfigProperty
+      .key("hoodie.meta.sync.datahub.tls.ca.cert.path")
+      .noDefaultValue()
+      .markAdvanced()
+      .withDocumentation("Path to the CA certificate file for TLS 
verification. "
+          + "Used when connecting to DataHub over HTTPS with custom CA 
certificates.");
+
+  public static final ConfigProperty<String> 
META_SYNC_DATAHUB_TLS_KEYSTORE_PATH = ConfigProperty
+      .key("hoodie.meta.sync.datahub.tls.keystore.path")
+      .noDefaultValue()
+      .markAdvanced()
+      .withDocumentation("Path to the keystore file for TLS client 
authentication. "
+          + "Used when connecting to DataHub over HTTPS with mutual TLS 
authentication.");
+
+  public static final ConfigProperty<String> 
META_SYNC_DATAHUB_TLS_KEYSTORE_PASSWORD = ConfigProperty
+      .key("hoodie.meta.sync.datahub.tls.keystore.password")
+      .noDefaultValue()
+      .markAdvanced()
+      .withDocumentation("Password for the keystore file. Optional but 
recommended for security. "
+          + "If not provided, an empty password will be used.");
+
+  public static final ConfigProperty<String> 
META_SYNC_DATAHUB_TLS_TRUSTSTORE_PATH = ConfigProperty
+      .key("hoodie.meta.sync.datahub.tls.truststore.path")
+      .noDefaultValue()
+      .markAdvanced()
+      .withDocumentation("Path to the truststore file for TLS server 
verification. "
+          + "Alternative to CA certificate file for trust management.");
+
+  public static final ConfigProperty<String> 
META_SYNC_DATAHUB_TLS_TRUSTSTORE_PASSWORD = ConfigProperty
+      .key("hoodie.meta.sync.datahub.tls.truststore.password")
+      .noDefaultValue()
+      .markAdvanced()
+      .withDocumentation("Password for the truststore file. Optional but 
recommended for security. "
+          + "If not provided, an empty password will be used.");

Review Comment:
   added



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to