garyli1019 commented on a change in pull request #2296: URL: https://github.com/apache/hudi/pull/2296#discussion_r544993950
########## File path: hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestCOWDataSource.scala ########## @@ -320,4 +320,21 @@ class TestCOWDataSource extends HoodieClientTestBase { assertTrue(HoodieDataSourceHelpers.hasNewCommits(fs, basePath, "000")) } + + @Test def testWithEmptyInput(): Unit = { + val inputDF1 = spark.read.json(spark.sparkContext.parallelize(Seq.empty[String], 1)) + inputDF1.write.format("org.apache.hudi") + .options(commonOpts) + .option(DataSourceWriteOptions.OPERATION_OPT_KEY, DataSourceWriteOptions.INSERT_OPERATION_OPT_VAL) + .mode(SaveMode.Overwrite) + .save(basePath) + assertTrue(HoodieDataSourceHelpers.hasNewCommits(fs, basePath, "000")) Review comment: I might be mistaken here. I see delta streamer and Flink could also make an empty commit. If empty commits are not considering as a bug, then this should be fine. cc: @bvaradar @vinothchandar can you guys make the call here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org