danny0405 commented on code in PR #14126:
URL: https://github.com/apache/hudi/pull/14126#discussion_r2454201603
##########
hudi-common/src/main/java/org/apache/hudi/internal/schema/io/FileBasedInternalSchemaStorageManager.java:
##########
@@ -107,7 +107,7 @@ private void cleanResidualFiles() {
.filter(f -> f.isFile())
.map(file ->
file.getPath().getName()).collect(Collectors.toList());
List<String> residualSchemaFiles =
- candidateSchemaFiles.stream().filter(f ->
!validateCommits.contains(f.split("\\.")[0]))
+ candidateSchemaFiles.stream().filter(f ->
!validateCommits.contains(getMetaClient().getInstantFileNameParser().extractTimestamp(f)))
Review Comment:
what about line 133? and what is the file name that breaks the old rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
